Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Reorganize structure and design #187

Closed
wants to merge 1 commit into from

Conversation

dagwieers
Copy link
Collaborator

@dagwieers dagwieers commented May 5, 2019

Things I would like to do:

  • Use a routing library for having a more simple interface
  • Rename overly long functions, e.g. get_localized_string()
  • Move all python files into a single directory

This is a work-in-progress.

This fixes #103 and #176

@dagwieers dagwieers added the enhancement New feature or request label May 5, 2019
@dagwieers dagwieers added this to the v2.0.0 milestone May 5, 2019
@dagwieers
Copy link
Collaborator Author

dagwieers commented May 5, 2019

One big problem with script.module.routing is that URLs (or anything with slashes) cannot be passed through (needs explicit quote/unquote). Another problem is that the global plugin object needs to be passed on as well, while I had hoped that this would not be needed. So it's an even more radical change than I had hoped.

I have some working code for some of the menu listings, but it requires a lot more work. Feel free to discuss any design changes in the current PR, because there's a lot going on.

@mediaminister
Copy link
Collaborator

I don't like script.module.routing, I think a separate navigation function is good enough. For instance: https://github.com/mediaminister/plugin.video.vrt.nu/blob/fast/resources/lib/vrtnu/vrtnu.py#L24

@dagwieers dagwieers mentioned this pull request May 8, 2019
@dagwieers
Copy link
Collaborator Author

So my approach for this will be to reorganize everything except the existing routing, so that existing paths do not break. However, I think we need to redesign that part at some point as well. But we can go to great length without affecting this for now.

@dagwieers
Copy link
Collaborator Author

Some of this will happen in another PR, some day.

@dagwieers dagwieers closed this May 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move to using script.module.routing
2 participants